Fix incorrect circular reference detection #1566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1565
Circular reference detection released in v0.42.0 is broken. The detection logic builds a call stack and determines that it is circular-referenced if the same address appears multiple times.
This call stack should literally be the stack. It should be popped after every push instead of clearing it at the end. The current detection logic detects erroneous circular references when the same local value appears multiple times in the middle.
This PR fixes the detection logic by using the stack correctly.